lhotari commented on a change in pull request #9308:
URL: https://github.com/apache/pulsar/pull/9308#discussion_r602248241
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -175,6 +175,7 @@
@Setter(AccessLevel.PROTECTED)
public class BrokerService implements Closeable,
ZooKeeperCacheListener<Policies> {
private static final Logger log =
LoggerFactory.getLogger(BrokerService.class);
+ private static final int CHANNEL_CLOSE_TIMEOUT_SECONDS = 10;
Review comment:
I'm adding a short explanation here. The solution changed after the
comment was made. The proposal by Matteo in
https://github.com/apache/pulsar/pull/9308#discussion_r565390915 was to use the
existing `brokerShutdownTimeoutMs` setting for the port closing. This resulted
in the changes that are in the PR currently. I'd suggest reviewing the final
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
