abhilashmandaliya commented on a change in pull request #10028:
URL: https://github.com/apache/pulsar/pull/10028#discussion_r602503903
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
##########
@@ -669,18 +675,105 @@ public void close() throws PulsarClientException {
@Override
public void shutdown() throws PulsarClientException {
try {
- lookup.close();
- cnxPool.close();
- timer.stop();
- externalExecutorProvider.shutdownNow();
- internalExecutorService.shutdownNow();
- conf.getAuthentication().close();
Review comment:
@MarvinCai @315157973
if we go with the boolean flag option, then the same needs to be passed to
the ConnectionPool as it is also using the same eventLoopGroup. Putting a check
on cnxPool.close at the caller site is not safe as ConnectionPool.close is
closing some other resources as well. Adding such boolean parameter to the
public constructor looks odd. So we can create a protected or package private
constructor in ConnectionPool which will accept this new boolean param. Does
that look good to you people or you have some other better choice here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
