merlimat commented on a change in pull request #10028:
URL: https://github.com/apache/pulsar/pull/10028#discussion_r607238925
##########
File path:
pulsar-client-api/src/main/java/org/apache/pulsar/client/api/PulsarClient.java
##########
@@ -281,7 +281,8 @@ static ClientBuilder builder() {
* Perform immediate shutdown of PulsarClient.
*
* <p>Release all the resources and close all the producer, consumer and
reader instances without waiting
- * for ongoing operations to complete.
+ * for ongoing operations to complete. Resources passed from the outside
like EventLoopGroup or ConnectionPool
+ * will not be closed.
Review comment:
`EventLoopGroup` and `ConnectionPool` classes are not part of the public
API (even though they can be passed to a `PulsarClientImpl` constructor, which
is not public), so they should not be mentioned here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
