cimura commented on a change in pull request #10045:
URL: https://github.com/apache/pulsar/pull/10045#discussion_r602984748
##########
File path: site2/docs/client-libraries-node.md
##########
@@ -125,9 +128,11 @@ Pulsar Node.js producers have the following methods
available:
| Method | Description | Return type |
| :----- | :---------- | :---------- |
-| `send(Object)` | Publishes a [message](#messages) to the producer's topic.
When the message is successfully acknowledged by the Pulsar broker, or an error
will be thrown, the Promise object run executor function. | `Promise<null>` |
-| `flush()` | Sends message from send queue to Pulser broker. When the message
is successfully acknowledged by the Pulsar broker, or an error will be thrown,
the Promise object run executor function. | `Promise<null>` |
-| `close()` | Closes the producer and releases all resources allocated to it.
If `close()` is called then no more messages will be accepted from the
publisher. This method will return Promise object, and when all pending publish
requests have been persisted by Pulsar then run executor function. If an error
is thrown, no pending writes will be retried. | `Promise<null>` |
+| `send(Object)` | Publishes a [message](#messages) to the producer's topic.
When the message is successfully acknowledged by the Pulsar broker, or an error
will be thrown, the Promise object whose result is the message ID runs executor
function. | `Promise<Object>` |
+| `flush()` | Sends message from send queue to Pulser broker. When the message
is successfully acknowledged by the Pulsar broker, or an error will be thrown,
the Promise object runs executor function. | `Promise<null>` |
+| `close()` | Closes the producer and releases all resources allocated to it.
If `close()` is called then no more messages will be accepted from the
publisher. This method will return Promise object, and when all pending publish
requests have been persisted by Pulsar then runs executor function. If an error
is thrown, no pending writes will be retried. | `Promise<null>` |
Review comment:
fixed this.
https://github.com/apache/pulsar/pull/10045/commits/7a6356373ea03a11948c474f5616592148c48bf1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
