Anonymitaet commented on a change in pull request #10045:
URL: https://github.com/apache/pulsar/pull/10045#discussion_r603241238
##########
File path: site2/docs/client-libraries-node.md
##########
@@ -219,12 +224,15 @@ Pulsar Node.js consumers have the following methods
available:
| `negativeAcknowledge(Message)`| [Negatively
acknowledges](reference-terminology.md#negative-acknowledgment-nack) a message
to the Pulsar broker by message object. | `void` |
| `negativeAcknowledgeId(MessageId)` | [Negatively
acknowledges](reference-terminology.md#negative-acknowledgment-nack) a message
to the Pulsar broker by message ID object. | `void` |
| `close()` | Closes the consumer, disabling its ability to receive messages
from the broker. | `Promise<null>` |
+| `unsubscribe()` | Unsubscribes the subscription. | `Promise<null>` |
### Consumer configuration
| Parameter | Description | Default |
| :-------- | :---------- | :------ |
-| `topic` | The Pulsar [topic](reference-terminology.md#topic) on which the
consumer will establish a subscription and listen for messages. | |
+| `topic` | The Pulsar topic on which the consumer will establish a
subscription and listen for messages. | |
Review comment:
same comment as previously (use present tense)
##########
File path: site2/docs/client-libraries-node.md
##########
@@ -389,6 +397,8 @@ The following keys are available for producer message
objects:
| `sequenceId` | The sequence ID of the message. |
| `partitionKey` | The optional key associated with the message (particularly
useful for things like topic compaction). |
| `replicationClusters` | The clusters to which this message will be
replicated. Pulsar brokers handle message replication automatically; you should
only change this setting if you want to override the broker default. |
+| `deliverAt` | The absolute timestamp at or after which the message is
delivered. | |
Review comment:
OK, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
