MarvinCai commented on a change in pull request #10093:
URL: https://github.com/apache/pulsar/pull/10093#discussion_r605336644
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
##########
@@ -2276,6 +2277,57 @@ public boolean isBacklogExceeded() {
return (storageSize >= backlogQuotaLimitInBytes);
}
+ /**
+ * @return determine if backlog quota enforcement needs to be done for
topic based on time limit
+ */
+ public boolean isTimeBacklogExceeded() {
Review comment:
Yes, I agree, reading first entry in backlog of slowest cursor will
mostly causing read from BK disk which could affect overall performance, but
using metadata could also affect accuracy as you mentioned, how about we have
both and make it configurable so user can make their own decision? We can have
the metadata one as default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
