MarvinCai commented on a change in pull request #10093:
URL: https://github.com/apache/pulsar/pull/10093#discussion_r607377708
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/BacklogQuota.java
##########
@@ -28,16 +28,27 @@
* <code>limit</code> representing a quota limit in bytes and
<code>policy</code> for backlog retention policy.
*/
public class BacklogQuota {
- private long limit;
+ private long limitSize;
+ // backlog quota by time in second
+ private int limitTime;
private RetentionPolicy policy;
/**
- * Gets quota limit in bytes.
+ * Gets quota limit in size.
*
* @return quota limit in bytes
*/
- public long getLimit() {
- return limit;
+ public long getLimitSize() {
Review comment:
Good catch, I actually missed that. Added compatibility conversion and a
unit test to make sure it works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
