sijie commented on a change in pull request #10113:
URL: https://github.com/apache/pulsar/pull/10113#discussion_r605878299
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -342,7 +345,14 @@ private void sendOutputMessage(Record srcRecord, Object
output) {
Thread.currentThread().setContextClassLoader(functionClassLoader);
}
try {
- this.sink.write(new SinkRecord<>(srcRecord, output));
+ SinkRecord sinkRecord;
Review comment:
I don't understand why do you need this change here. What is the value
for adding a SinkKVRecord? SinkRecord is a wrapper of the output object. The
output object can be a KeyValue object.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
