eolivelli commented on a change in pull request #10113:
URL: https://github.com/apache/pulsar/pull/10113#discussion_r606173882
##########
File path:
pulsar-functions/instance/src/main/java/org/apache/pulsar/functions/instance/JavaInstanceRunnable.java
##########
@@ -342,7 +345,14 @@ private void sendOutputMessage(Record srcRecord, Object
output) {
Thread.currentThread().setContextClassLoader(functionClassLoader);
}
try {
- this.sink.write(new SinkRecord<>(srcRecord, output));
+ SinkRecord sinkRecord;
Review comment:
@sijie the alternative is:
- make KeyValueSchema part of the "public" API (or add an interface on the
"api" package)
- hide "AutoConsumeSchema" in the Sink side and make Record#getSchema()
return the current KeyValueSchema
but this alternative is not good because:
- we are going to add a new API to represent KeyValueSchema, but we already
have KVRecord
- we are changing the behaviour of the Sink, not returning AutoConsumeSchema
anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
