jerrypeng commented on a change in pull request #10156:
URL: https://github.com/apache/pulsar/pull/10156#discussion_r612143140
##########
File path:
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -544,6 +552,11 @@ private void
startThreadedMode(org.apache.pulsar.functions.proto.Function.Functi
if (functionConfig != null &&
functionConfig.getExposePulsarAdminClientEnabled() != null) {
exposePulsarAdminClientEnabled =
functionConfig.getExposePulsarAdminClientEnabled();
}
+
+ // Collector Registry for prometheus metrics
+ CollectorRegistry collectorRegistry = new CollectorRegistry();
Review comment:
@michaeljmarshall yup thus after some thinking, I can up with a new PR:
https://github.com/apache/pulsar/pull/10208
For running instances as threads with in the local run JVM, it doesn't make
sense to run a metrics server per instance. Better user experience to just run
one metrics server and expose all of the metrics for all instances on the same
port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
