michaeljmarshall commented on a change in pull request #10156:
URL: https://github.com/apache/pulsar/pull/10156#discussion_r612165891
##########
File path:
pulsar-functions/localrun/src/main/java/org/apache/pulsar/functions/LocalRunner.java
##########
@@ -544,6 +552,11 @@ private void
startThreadedMode(org.apache.pulsar.functions.proto.Function.Functi
if (functionConfig != null &&
functionConfig.getExposePulsarAdminClientEnabled() != null) {
exposePulsarAdminClientEnabled =
functionConfig.getExposePulsarAdminClientEnabled();
}
+
+ // Collector Registry for prometheus metrics
+ CollectorRegistry collectorRegistry = new CollectorRegistry();
Review comment:
> Better user experience to just run one metrics server and expose all
of the metrics for all instances on the same port.
I agree. Although, it looks like the new PR still has metrics at `p` ports
where `p = parallelism`. I'll add a note to the new PR too, but wanted to
comment here, where you mentioned a single port.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
