jerrypeng edited a comment on pull request #10446: URL: https://github.com/apache/pulsar/pull/10446#issuecomment-834062620
I don't see any red flags in this PR but I also don't understand adding this functionality will be useful. @dlg99 based the comments https://github.com/apache/pulsar/pull/9927#discussion_r621441678 It seem like the subscription type should be checked at submission time and be rejected if a wrong subscription type is used. If we are checking the subscription type during the sink open, what are we going to do if the subscription type is wrong? Just go into a crash loop? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
