dlg99 commented on pull request #10446: URL: https://github.com/apache/pulsar/pull/10446#issuecomment-834070801
> If we are checking the subscription type during the sink open, what are we going to do if the subscription type is wrong? Just go into a crash loop? @jerrypeng This is not different from what's happening in other connectors now. I agree we can consider adding something to handle it better, but this is out of the scope of this PR. https://github.com/apache/pulsar/blob/5a1264dfc2ccf5a22c76e0385b219b2104c8e9ba/pulsar-io/kafka/src/main/java/org/apache/pulsar/io/kafka/KafkaAbstractSink.java#L84-L91 https://github.com/apache/pulsar/blob/5a1264dfc2ccf5a22c76e0385b219b2104c8e9ba/pulsar-io/kinesis/src/main/java/org/apache/pulsar/io/kinesis/KinesisSink.java#L159-L163 etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
