eolivelli commented on a change in pull request #10552:
URL: https://github.com/apache/pulsar/pull/10552#discussion_r630902440
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/PulsarService.java
##########
@@ -1515,6 +1515,7 @@ public static WorkerConfig
initializeWorkerConfigFromBrokerConfig(ServiceConfigu
String hostname =
ServiceConfigurationUtils.getDefaultOrConfiguredAddress(
ServiceConfigurationUtils.getAppliedAdvertisedAddress(brokerConfig));
workerConfig.setWorkerHostname(hostname);
+ workerConfig.setPulsarFunctionsCluster(brokerConfig.getClusterName());
Review comment:
what about setting this `brokerConfig.getClusterName()` value only if
the user did not configure another value ?
otherwise this change may introduce a behaviour change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
