wangjialing218 commented on pull request #10552:
URL: https://github.com/apache/pulsar/pull/10552#issuecomment-840219636
> if `setPulsarFunctionsCluster` is required for making the broker work.
> do we have test cases that set that value ?
> we have to fix all of those tests and remove the call to
`setPulsarFunctionsCluster`
> does it make sense to you ?
>
@eolivelli I have modify exist test case to meet this change, please have a
check
> it looks like it is useless to set a value explicitly if you cannot change
it
>
Currently default value of FunctionsCluster is loaded from
`functions_worker.yml`.
When we start function woker separately, we need to set FunctionsCluster in
`functions_worker.yml` because we can not get cluster name directly from broker.
And when we start function worker with broker, we can get cluster name
directly from broker config, no need to load the value from
‘functions_worker.yml’.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
