wangjialing218 commented on pull request #10710: URL: https://github.com/apache/pulsar/pull/10710#issuecomment-849499080
I have two suggestions: 1. There are too many paramaters for tls setting in `CmdClusters`. Could we combine all remote cluster auth setting to one paramater as a JSON string, just like "--external-pulsars" in `CmdFunctions` https://github.com/apache/pulsar/blob/5a7ba52193c069bc40705bcdc74287aae1066b17/pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdFunctions.java#L325 2. Compared with `AuthenticationConfig` class, `tlsHostnameVerificationEnable` is missed. Shoud this paramter also be config in geo-replicator? https://github.com/apache/pulsar/blob/6704f12104219611164aa2bb5bbdfc929613f1bf/pulsar-common/src/main/java/org/apache/pulsar/common/functions/AuthenticationConfig.java#L35 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
