gaoran10 commented on a change in pull request #10710:
URL: https://github.com/apache/pulsar/pull/10710#discussion_r642744964



##########
File path: 
pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdClusters.java
##########
@@ -83,11 +83,67 @@ void run() throws PulsarAdminException {
         @Parameter(names = "--proxy-protocol", description = "protocol to 
decide type of proxy routing eg: SNI", required = false)
         private ProxyProtocol proxyProtocol;
 
+        @Parameter(names = "--tls-enable", description = "Enable tls 
connection", required = false)
+        private boolean brokerClientTlsEnabled = false;
+
+        @Parameter(names = "--tls-allow-insecure", description = "Allow 
insecure tls connection", required = false)
+        private boolean tlsAllowInsecureConnection = false;
+
+        @Parameter(names = "--tls-enable-keystore", description = "Whether use 
KeyStore type to authenticate", required = false)
+        private boolean brokerClientTlsEnabledWithKeyStore = false;
+
+        @Parameter(names = "--tls-trust-store-type", description = "TLS 
TrustStore type configuration for internal client eg: JKS", required = false)
+        private String brokerClientTlsTrustStoreType = "JKS";
+
+        @Parameter(names = "--tls-trust-store", description = "TLS TrustStore 
path for internal client", required = false)
+        private String brokerClientTlsTrustStore;
+
+        @Parameter(names = "--tls-trust-store-pwd", description = "TLS 
TrustStore password for internal client", required = false)
+        private String brokerClientTlsTrustStorePassword;
+
+        @Parameter(names = "--tls-trust-certs-filepath", description = "path 
for the trusted TLS certificate file", required = false)
+        private String brokerClientTrustCertsFilePath;
+

Review comment:
       Maybe we could add a new base class for Create and Update command, there 
are many same configurations.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to