jerrypeng commented on a change in pull request #10685:
URL: https://github.com/apache/pulsar/pull/10685#discussion_r643340844
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java
##########
@@ -66,6 +69,10 @@ default String authenticate(AuthenticationDataSource
authData) throws Authentica
throw new AuthenticationException("Not supported");
}
+ default List<String> authenticate(AuthenticationDataSource authData,
boolean multiRoles) throws AuthenticationException {
Review comment:
I do agree that the nomenclature we are using is very confusing. Some
times we interchangeably use "principal" and "role" when by definition they can
and should mean different things. However, this seems like an existing issue
not necessarily introduced in this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
