jerrypeng commented on a change in pull request #10685:
URL: https://github.com/apache/pulsar/pull/10685#discussion_r643342945
##########
File path:
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authentication/AuthenticationProvider.java
##########
@@ -66,6 +69,10 @@ default String authenticate(AuthenticationDataSource
authData) throws Authentica
throw new AuthenticationException("Not supported");
}
+ default List<String> authenticate(AuthenticationDataSource authData,
boolean multiRoles) throws AuthenticationException {
Review comment:
However, I don't understand why we need to pass in the boolean argument
`multiRoles`. There is already a method, i.e. `isSupportMultiRoles()`, that
returns whether the authenication provider supports multi-role or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
