lhotari commented on a change in pull request #10804:
URL: https://github.com/apache/pulsar/pull/10804#discussion_r644632287
##########
File path: site2/tools/build-site.sh
##########
@@ -34,44 +34,55 @@ if [ "$CROWDIN_DOCUSAURUS_API_KEY" != "UNSET" ]; then
# or current hour is 0-5
# this leads to executing crowdin-upload once per day when website build is
scheduled
# to run with cron expression '0 */6 * * *'
- CURRENT_HOUR=`date +%H`
+ CURRENT_HOUR=$(date +%H)
if [[ "$CROWDIN_UPLOAD" == "1" || $CURRENT_HOUR -lt 6 ]]; then
yarn run crowdin-upload
fi
yarn run crowdin-download
-fi
-# TODO: remove this after figuring out why crowdin removed code tab when
generating translated files
Review comment:
Is that something @tuteng or you could take care of since I'm not
familiar with Crowdin. This PR simply makes it possible to run and debug the
site building locally without the Crowdin parts.
I'd suggest that we do refactorings separately from this PR. Is that fine
for you @sijie?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
