tuteng commented on a change in pull request #10804:
URL: https://github.com/apache/pulsar/pull/10804#discussion_r645139850
##########
File path: site2/tools/build-site.sh
##########
@@ -34,44 +34,55 @@ if [ "$CROWDIN_DOCUSAURUS_API_KEY" != "UNSET" ]; then
# or current hour is 0-5
# this leads to executing crowdin-upload once per day when website build is
scheduled
# to run with cron expression '0 */6 * * *'
- CURRENT_HOUR=`date +%H`
+ CURRENT_HOUR=$(date +%H)
if [[ "$CROWDIN_UPLOAD" == "1" || $CURRENT_HOUR -lt 6 ]]; then
yarn run crowdin-upload
fi
yarn run crowdin-download
-fi
-# TODO: remove this after figuring out why crowdin removed code tab when
generating translated files
Review comment:
I currently think this part can be removed, because newer versions since
2.5.2 have not added the corresponding content, but the site is built
successfully, so I will consider doing a test to decide whether to remove the
hack content
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
