gaoran10 commented on a change in pull request #11116:
URL: https://github.com/apache/pulsar/pull/11116#discussion_r659455861
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -3361,7 +3359,7 @@ private boolean currentLedgerIsFull() {
|| currentLedgerSize >= (config.getMaxSizePerLedgerMb() *
MegaByte));
long timeSinceLedgerCreationMs = clock.millis() -
lastLedgerCreatedTimestamp;
- boolean maxLedgerTimeReached = timeSinceLedgerCreationMs >=
maximumRolloverTimeMs;
+ boolean maxLedgerTimeReached = timeSinceLedgerCreationMs >=
config.getMaximumRolloverTimeMs();
Review comment:
Maybe the random maximum rollover time should be used to control the
scheduled task? And use the original configuration to check the ledger whether
reach the max rollover time threshold.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
