eolivelli commented on a change in pull request #11116:
URL: https://github.com/apache/pulsar/pull/11116#discussion_r659645977
##########
File path:
managed-ledger/src/test/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerTest.java
##########
@@ -2922,6 +2922,23 @@ public void testManagedLedgerRollOverIfFull() throws
Exception {
Assert.assertEquals(ledger.getTotalSize(), 0);
}
+ @Test
+ public void testLedgerReachMaximumRolloverTime() throws Exception {
+ ManagedLedgerConfig config = new ManagedLedgerConfig();
+ config.setRetentionTime(1, TimeUnit.SECONDS);
+ config.setMaxEntriesPerLedger(2);
+ config.setMinimumRolloverTime(1, TimeUnit.MILLISECONDS);
+ config.setMaximumRolloverTime(1, TimeUnit.SECONDS);
+
+ ManagedLedger ml = factory.open("ledger-reach-maximum-rollover-time",
config);
+ Position position1 = ml.addEntry("test".getBytes());
+
+ Thread.sleep(1000);
Review comment:
what happens on a slow machine ?
will the test fail ?
what are you testing here ? is there a better way to test what you want ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
