mattisonchao commented on pull request #10986: URL: https://github.com/apache/pulsar/pull/10986#issuecomment-870934774
> Did you see some measurable improvement? > > I am saying this because recently JVM handle string concatenation better that using StringBuilder in same cases and forcing a concatenation strategy sometimes it is not the best option. > > That said I am not against this change, but I just want to know if this is the result of some static code analysis or it is fixing a real problem. You know the motto 'don't fix things that are not broken Thanks for your suggestion, Could you provide me with some material on how the JVM improves the performance of string concatenation? I didn't find it~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
