mattisonchao commented on pull request #10986: URL: https://github.com/apache/pulsar/pull/10986#issuecomment-871354007
> @mattisonchao I am pretty sure that this code is not for JDK11. > > when you build this code with JDK11 with target = 11 the result will be very different. > > btw we are still building Pulsar for JDK8, so the change is good for me You are right. The JVM handles string concatenation better than using StringBuilder in some cases. The doc is here: https://docs.oracle.com/javase/9/docs/api/java/lang/invoke/StringConcatFactory.html#makeConcat-java.lang.invoke.MethodHandles.Lookup-java.lang.String-java.lang.invoke.MethodType- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
