eolivelli commented on a change in pull request #11238: URL: https://github.com/apache/pulsar/pull/11238#discussion_r669427393
########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/NativeAvroBytesSchema.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.impl.schema; + +import static com.google.common.base.Preconditions.checkState; + +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.client.api.schema.SchemaDefinition; +import org.apache.pulsar.common.schema.SchemaInfo; +import org.apache.pulsar.common.schema.SchemaType; + +import java.util.Optional; + +/** + * Schema from a native Apache Avro schema. + * This class is supposed to be used for working with existing data serialized in Avro, possibly stored in another system like Kafka. + * For this reason, it will not perform bytes validation against the schema in encoding and decoding, which are just identify functions. + * This class also makes it possible for users to bring in their own Avro serializer/deserializer. + */ +public class NativeAvroBytesSchema<T> implements Schema<byte[]> { + + private Schema<T> schema; + private org.apache.avro.Schema nativeSchema; + + public NativeAvroBytesSchema(org.apache.avro.Schema schema) { + setSchema(schema); + } + + public NativeAvroBytesSchema(Object schema) { + this(validateSchema(schema)); + } + + public void setSchema(org.apache.avro.Schema schema) { + SchemaDefinition schemaDefinition = SchemaDefinition.builder().withJsonDef(schema.toString(false)).build(); + this.nativeSchema = schema; + this.schema = AvroSchema.of(schemaDefinition); + } + + public boolean schemaInitialized() { + return schema != null; + } + + private static org.apache.avro.Schema validateSchema (Object schema) { + if (! (schema instanceof org.apache.avro.Schema)) + throw new IllegalArgumentException("The input schema is not of type 'org.apache.avro.Schema'."); + return (org.apache.avro.Schema) schema; + } + + private void ensureSchemaInitialized() { + checkState(schemaInitialized(), "Schema is not initialized before used"); + } + + @Override + public byte[] encode(byte[] message) { + ensureSchemaInitialized(); + + return message; + } + + @Override + public byte[] decode(byte[] bytes, byte[] schemaVersion) { + ensureSchemaInitialized(); + + return bytes; + } + + @Override + public SchemaInfo getSchemaInfo() { + ensureSchemaInitialized(); + + return schema.getSchemaInfo(); + } + + @Override + public Optional<Object> getNativeSchema() { + return Optional.ofNullable(this.nativeSchema); Review comment: it cannot be null ########## File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/schema/NativeAvroBytesSchema.java ########## @@ -0,0 +1,100 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pulsar.client.impl.schema; + +import static com.google.common.base.Preconditions.checkState; + +import org.apache.pulsar.client.api.Schema; +import org.apache.pulsar.client.api.schema.SchemaDefinition; +import org.apache.pulsar.common.schema.SchemaInfo; +import org.apache.pulsar.common.schema.SchemaType; + +import java.util.Optional; + +/** + * Schema from a native Apache Avro schema. + * This class is supposed to be used for working with existing data serialized in Avro, possibly stored in another system like Kafka. + * For this reason, it will not perform bytes validation against the schema in encoding and decoding, which are just identify functions. + * This class also makes it possible for users to bring in their own Avro serializer/deserializer. + */ +public class NativeAvroBytesSchema<T> implements Schema<byte[]> { + + private Schema<T> schema; + private org.apache.avro.Schema nativeSchema; + + public NativeAvroBytesSchema(org.apache.avro.Schema schema) { + setSchema(schema); + } + + public NativeAvroBytesSchema(Object schema) { + this(validateSchema(schema)); + } + + public void setSchema(org.apache.avro.Schema schema) { + SchemaDefinition schemaDefinition = SchemaDefinition.builder().withJsonDef(schema.toString(false)).build(); + this.nativeSchema = schema; + this.schema = AvroSchema.of(schemaDefinition); + } + + public boolean schemaInitialized() { + return schema != null; + } + + private static org.apache.avro.Schema validateSchema (Object schema) { + if (! (schema instanceof org.apache.avro.Schema)) + throw new IllegalArgumentException("The input schema is not of type 'org.apache.avro.Schema'."); + return (org.apache.avro.Schema) schema; + } + + private void ensureSchemaInitialized() { + checkState(schemaInitialized(), "Schema is not initialized before used"); + } + + @Override + public byte[] encode(byte[] message) { + ensureSchemaInitialized(); + + return message; + } + + @Override + public byte[] decode(byte[] bytes, byte[] schemaVersion) { + ensureSchemaInitialized(); + + return bytes; + } + + @Override + public SchemaInfo getSchemaInfo() { + ensureSchemaInitialized(); + + return schema.getSchemaInfo(); + } + + @Override + public Optional<Object> getNativeSchema() { + return Optional.ofNullable(this.nativeSchema); + } + + @Override + public Schema<byte[]> clone() { + return new AutoProduceBytesSchema<>(schema.clone()); Review comment: `return new NativeAvroBytesSchema(nativeSchema)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
