Zhen-hao commented on pull request #11238: URL: https://github.com/apache/pulsar/pull/11238#issuecomment-879818983
> Did you try to use the debugger with a break point in that point ? probably you have not overridden every method in the Schema interface. > > by the way I believe that your new `NativeAvroBytesSchema` is useful only for the Producer. > if you want to read raw bytes you simply do not set a Schema in the consumer or you use Schema.BYTES. > > `NativeAvroBytesSchema`does not perform validation and it does not decode the payload, so it is not worth to be used on the Consumer side. > > I suggest you to: > > * throw UnsupportedOperationException in all "decode" methods of NativeAvroBytesSchema > * write explicitly in the Javadoc that this is a Schema to be used on the Producer side > * use Schema.BYTES (or no Schema) in the Consumer in your test You are right. I've made the changes as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
