eolivelli commented on a change in pull request #11370:
URL: https://github.com/apache/pulsar/pull/11370#discussion_r672295547
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
##########
@@ -62,7 +67,7 @@ protected void setup() throws Exception {
conf.setBookiePort(0);
conf.setZkServers("127.0.0.1:" + bkEnsemble.getZookeeperPort());
conf.setJournalDirName(bkDataDir.getPath());
- conf.setLedgerDirNames(new String[] { bkDataDir.getPath() });
+ conf.setLedgerDirNames(new String[]{bkDataDir.getPath()});
Review comment:
can you please revert formatting ?
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
##########
@@ -79,7 +84,7 @@ protected void setup() throws Exception {
}
- @AfterClass(alwaysRun = true)
Review comment:
is this necessary ?
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
##########
@@ -50,10 +57,8 @@ public RackAwareTest() {
super(0);
}
- @BeforeClass(alwaysRun = true)
- protected void setup() throws Exception {
Review comment:
(probably it is okay, but I want to double check)
why are you removing this ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
