lhotari commented on a change in pull request #11370:
URL: https://github.com/apache/pulsar/pull/11370#discussion_r674555803
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
##########
@@ -79,7 +84,7 @@ protected void setup() throws Exception {
}
- @AfterClass(alwaysRun = true)
Review comment:
there's some oddities when using the TestNG After/Before annotations in
tests. There's some cases where the method doesn't get called at all.
@Technoboy- I made some observations that super class After/Before
annotations will only get called if they are public methods. It must be some
kind of TestNG bug. Please change "protected void cleanup" to "public void
cleanup" both in this class and also in the base class which is
BkEnsemblesTestBase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
