lhotari commented on a change in pull request #11370:
URL: https://github.com/apache/pulsar/pull/11370#discussion_r674736449
##########
File path:
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/RackAwareTest.java
##########
@@ -79,7 +84,7 @@ protected void setup() throws Exception {
}
- @AfterClass(alwaysRun = true)
Review comment:
Actually, I take my words back. TestNG seems to behave in a very strange
way when After/Before annotations are defined on a super class method and the
method is overridden. I tested this and what happens is that "cleanup" gets run
as a test method before any other methods and cleanup never gets called. I
guess the only way to prevent strange things from happening is to make
After/Before methods final and using template methods (such as configurePulsar
in BkEnsemblesTestBase).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
