cckellogg commented on a change in pull request #575:
URL: https://github.com/apache/pulsar-client-go/pull/575#discussion_r677984184
##########
File path: pulsar/producer_partition.go
##########
@@ -353,7 +353,7 @@ func (p *partitionProducer) internalSend(request
*sendRequest) {
payload := msg.Payload
var schemaPayload []byte
var err error
- if p.options.Schema != nil {
+ if p.options.Schema != nil && msg.Value != nil {
Review comment:
Is that a safe assumption to make? What happens on the consumer side if
that assumption does not hold?
I think we should at least add a comment explaining this because from
looking at the code it's not obvious to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
