cckellogg commented on a change in pull request #575:
URL: https://github.com/apache/pulsar-client-go/pull/575#discussion_r679266576
##########
File path: pulsar/producer_partition.go
##########
@@ -353,7 +353,7 @@ func (p *partitionProducer) internalSend(request
*sendRequest) {
payload := msg.Payload
var schemaPayload []byte
var err error
- if p.options.Schema != nil {
+ if p.options.Schema != nil && msg.Value != nil {
Review comment:
A few more questions. I'm trying to figure out how to best solve this
from an api perspective because if this goes in we are changing the api and
will have to support it.
It seems like it's possible to pass a custom implementation of a schema is
there a reason this can't solve the issue?
Why is app encoding the message before hand?
If the app is bypassing the internal encoder when producing does it need to
bypass internal decoder on the consumer side as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
