eolivelli commented on a change in pull request #11494:
URL: https://github.com/apache/pulsar/pull/11494#discussion_r678960727



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentSubscription.java
##########
@@ -150,6 +151,8 @@ public PersistentSubscription(PersistentTopic topic, String 
subscriptionName, Ma
         this.setReplicated(replicated);
         if 
(topic.getBrokerService().getPulsar().getConfig().isTransactionCoordinatorEnabled()
                 && !checkTopicIsEventsNames(TopicName.get(topicName))) {
+            ManagedLedgerConfig config = 
this.topic.getManagedLedger().getConfig();
+            config.setCreateIfMissing(true);

Review comment:
       this is still not good.
   you have to apply this setting elsewhere
   
   maybe @congbobo184 or @codelipenghui can help more




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to