liangyepianzhou commented on a change in pull request #11494:
URL: https://github.com/apache/pulsar/pull/11494#discussion_r681404352



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1232,6 +1232,7 @@ public void openLedgerComplete(ManagedLedger ledger, 
Object ctx) {
                                     preCreateSubForCompaction = ((SystemTopic) 
persistentTopic)
                                             
.preCreateSubForCompactionIfNeeded();
                                 }
+                                managedLedgerConfig.setCreateIfMissing(true);

Review comment:
       This may depend on the original design intention of getTopicIfExists. 
Calling getTopicIfExists will directly set createIfMissing to false, which will 
affect the configuration. I don't know if this is intentional or ignored.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to