This is an automated email from the ASF dual-hosted git repository.

penghui pushed a commit to branch branch-2.8
in repository https://gitbox.apache.org/repos/asf/pulsar.git

commit d4fd235351d4011d86dfb4b98cdf8fddf3b876d8
Author: GuoJiwei <[email protected]>
AuthorDate: Fri Jul 23 20:13:24 2021 +0800

    Remove duplicate check for replicationClusterSet (#11429)
    
    ### Motivation
    NamespacesBase#internalSetNamespaceReplicationClusters has duplicate codes:
    
https://github.com/apache/pulsar/blob/a6e1a3290d9eb42f4d03438c3ce9ced506ee8445/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java#L757-L773
    
    (cherry picked from commit 083bb62adfcadc9e2c61111214e0dca7054069d0)
---
 .../java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java | 9 ---------
 1 file changed, 9 deletions(-)

diff --git 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
index 19a228c..8eef925 100644
--- 
a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
+++ 
b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
@@ -751,15 +751,6 @@ public abstract class NamespacesBase extends AdminResource 
{
                 throw new RestException(Status.FORBIDDEN, "Invalid cluster id: 
" + clusterId);
             }
             validatePeerClusterConflict(clusterId, replicationClusterSet);
-        }
-        for (String clusterId : replicationClusterSet) {
-            if (!clusters.contains(clusterId)) {
-                throw new RestException(Status.FORBIDDEN, "Invalid cluster id: 
" + clusterId);
-            }
-            validatePeerClusterConflict(clusterId, replicationClusterSet);
-        }
-
-        for (String clusterId : replicationClusterSet) {
             validateClusterForTenant(namespaceName.getTenant(), clusterId);
         }
         updatePolicies(path(POLICIES, namespaceName.toString()), policies ->{

Reply via email to