This is an automated email from the ASF dual-hosted git repository. penghui pushed a commit to branch branch-2.8 in repository https://gitbox.apache.org/repos/asf/pulsar.git
commit 93f0e89ee4c54241128664e574ad5d5d45f40cc2 Author: WangJialing <[email protected]> AuthorDate: Fri Jul 23 20:14:56 2021 +0800 Add error log for schema admin operation (#11427) ### Motivation When I use pulsar-admin schemas to upload schema file with wrong format, I got `HTTP 500 Internal Server Error` from pulsar-admin-tool. And I look into broker's log but can not find any related error logs. ### Modifications export error log when schema admin operation failed. (cherry picked from commit 216623dc2e5e1b769d20fbb45c8b2e4e423d1fe3) --- .../apache/pulsar/broker/admin/impl/SchemasResourceBase.java | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java index 4f67d8b..2a857c4 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/SchemasResourceBase.java @@ -50,6 +50,8 @@ import org.apache.pulsar.common.protocol.schema.SchemaData; import org.apache.pulsar.common.protocol.schema.SchemaVersion; import org.apache.pulsar.common.schema.LongSchemaVersion; import org.apache.pulsar.common.schema.SchemaType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; public class SchemasResourceBase extends AdminResource { @@ -123,6 +125,7 @@ public class SchemasResourceBase extends AdminResource { .entity(DeleteSchemaResponse.builder().version(getLongSchemaVersion(version)).build()) .build()); } else { + log.error("[{}] Failed to delete schema for topic {}", clientAppId(), topicName, error); response.resume(error); } return null; @@ -162,6 +165,7 @@ public class SchemasResourceBase extends AdminResource { response.resume(Response.status(422, /* Unprocessable Entity */ error.getMessage()).build()); } else { + log.error("[{}] Failed to post schema for topic {}", clientAppId(), topicName, error); response.resume(Response.serverError().build()); } return null; @@ -173,6 +177,7 @@ public class SchemasResourceBase extends AdminResource { .status(((RestException) error.getCause()).getResponse().getStatus(), error.getMessage()) .build()); } else { + log.error("[{}] Failed to post schema for topic {}", clientAppId(), topicName, error); response.resume(Response.serverError().build()); } return null; @@ -224,6 +229,7 @@ public class SchemasResourceBase extends AdminResource { .thenAccept(version -> response.resume(Response.accepted() .entity(LongSchemaVersionResponse.builder().version(version).build()).build())) .exceptionally(error -> { + log.error("[{}] Failed to get version by schema for topic {}", clientAppId(), topicName, error); response.resume(Response.serverError().build()); return null; }); @@ -258,6 +264,7 @@ public class SchemasResourceBase extends AdminResource { .entity(convertSchemaAndMetadataToGetSchemaResponse(schema)).build()); } } else { + log.error("Failed to get schema", error); response.resume(error); } @@ -278,6 +285,7 @@ public class SchemasResourceBase extends AdminResource { .build()); } } else { + log.error("Failed to get all schemas", error); response.resume(error); } } @@ -294,4 +302,6 @@ public class SchemasResourceBase extends AdminResource { } } } + + private static final Logger log = LoggerFactory.getLogger(SchemasResourceBase.class); }
