codelipenghui commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r684873736
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/stats/metrics/ManagedCursorMetrics.java
##########
@@ -77,8 +85,32 @@ public ManagedCursorMetrics(PulsarService pulsar) {
metrics.put("brk_ml_cursor_persistLedgerErrors",
cStats.getPersistLedgerErrors());
metrics.put("brk_ml_cursor_persistZookeeperSucceed",
cStats.getPersistZookeeperSucceed());
metrics.put("brk_ml_cursor_persistZookeeperErrors",
cStats.getPersistZookeeperErrors());
+ metrics.put("brk_ml_cursor_writeLedgerSize",
cStats.getWriteCursorLedgerSize());
+ metrics.put("brk_ml_cursor_writeLedgerLogicalSize",
cStats.getWriteCursorLedgerLogicalSize());
+ metrics.put("brk_ml_cursor_readLedgerSize",
cStats.getReadCursorLedgerSize());
metricsCollection.add(metrics);
+
+ nsTotalNonContiguousDeletedMessagesRange +=
cursor.getTotalNonContiguousDeletedMessagesRange();
+ nsPersistLedgerSucceed += cStats.getPersistLedgerSucceed();
+ nsPersistLedgerErrors += cStats.getPersistLedgerErrors();
+ nsPersistZookeeperSucceed +=
cStats.getPersistZookeeperSucceed();
+ nsPersistZookeeperErrors += cStats.getPersistZookeeperErrors();
+ nsWriteCursorLedgerSize += cStats.getWriteCursorLedgerSize();
+ nsWriteCursorLedgerLogicalSize +=
cStats.getWriteCursorLedgerLogicalSize();
+ nsReadCursorLedgerSize += cStats.getReadCursorLedgerSize();
}
+
+ Metrics metrics = createMetricsByDimension(namespace);
+ metrics.put("brk_ml_cursor_nonContiguousDeletedMessagesRange",
+ nsTotalNonContiguousDeletedMessagesRange);
+ metrics.put("brk_ml_cursor_persistLedgerSucceed",
nsPersistLedgerSucceed);
+ metrics.put("brk_ml_cursor_persistLedgerErrors",
nsPersistLedgerErrors);
+ metrics.put("brk_ml_cursor_persistZookeeperSucceed",
nsPersistZookeeperSucceed);
+ metrics.put("brk_ml_cursor_persistZookeeperErrors",
nsPersistZookeeperErrors);
+ metrics.put("brk_ml_cursor_writeLedgerSize",
nsWriteCursorLedgerSize);
+ metrics.put("brk_ml_cursor_writeLedgerLogicalSize",
nsWriteCursorLedgerLogicalSize);
+ metrics.put("brk_ml_cursor_readLedgerSize",
nsReadCursorLedgerSize);
+ metricsCollection.add(metrics);
Review comment:
nice catch @michaeljmarshall I think we should only expose the namespace
dimension if exposeManagedCursorMetricsInPrometheus=false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
