michaeljmarshall commented on a change in pull request #11500:
URL: https://github.com/apache/pulsar/pull/11500#discussion_r685373234
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/ManagedCursorMXBean.java
##########
@@ -70,4 +70,33 @@
*/
long getPersistZookeeperErrors();
+ /**
+ * Add write data to a ledger of a cursor (in bytes).
+ *
+ * @param size Size of data written to cursor (in bytes)
+ */
+ void addWriteCursorLedgerSize(long size);
Review comment:
This method is updating two variables (`writeCursorLedgerSize` and
`writeCursorLedgerLogicalSize`). It would be helpful for future readers of this
interface to see the Javadoc explain what this method should update. Otherwise,
it would be confusing to see a `getWriteCursorLedgerLogicalSize` without an
associated `addWriteCursorLedgerLogicalSize` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
