abhilashmandaliya commented on pull request #11728: URL: https://github.com/apache/pulsar/pull/11728#issuecomment-903465777
> > Does this entire proposal of creating a message router at runtime using config look inappropriate and do you recommend handling the same at the application level > > Yes. It's better if we keep MessageRouter object creation in application and not at Pulsar-client because of multiple reasons: creation of MessageRouter object in pulsar-client doesn't solve any issue as it can be done by application as well in same way, creation of `MessageRouter` requires additional supporting configurations such as: Factory-class, properties map, new ClassLoader to make it right which can add unnecessary complication in `ProducerConfiguration`. also, this will be duplicate config for setting MessageRouter in a different way which doesn't add much value. So, it's better to keep such initialization of MessageRouter at application level and then we can set it into ProducerConfiguration. Applications will still have an option to set it manually but this is for cases in frameworks where it is harder to add factories or custom code and where you know the router can be simply constructed. Finally, I am fine with whatever you people decide :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
