abhilashmandaliya commented on pull request #11728: URL: https://github.com/apache/pulsar/pull/11728#issuecomment-904333005
> > but this is for cases in frameworks where it is harder to add factories or custom code > > Umm. but such applications anyway need to create `ProducerConfiguration` object so, creating MessageRouter and setting into `ProducerConfiguration` shouldn't be straight forward.? as I mentioned earlier, we need to consider more factors to make it correct: Factory class, properties map, class-loader and later on someone wants to add json properties (comma separated might not work), etc. so, I think it's better if we can keep such implementation outside client-lib and in actual appliation. Alright, I am closing the PR and issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
