tomscut commented on pull request #11880: URL: https://github.com/apache/pulsar/pull/11880#issuecomment-913299329
> > Hi @codelipenghui @hangc0276 , could you also please review the code? Thanks a lot. > > @tomscut Thanks for you contribution, if we remove the `log.isDebugEnabled()` check, it may cause more heap memory allocation and reduce performance. > https://logging.apache.org/log4j/log4j-2.3/performance.html IMO, This is just some scenarios that increase memory allocation. If there is only one parameter and it is an existing object, no additional memory allocation will be added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
