tomscut commented on pull request #11880: URL: https://github.com/apache/pulsar/pull/11880#issuecomment-913434519
> Thank you for your proposal > > But this is the current code style. > There are always long discussions about the need of these guards. > > If you want to change the style please start a discussion on [[email protected]](mailto:[email protected]) > This way the community will be able to discuss about this point. > > My personal take is that even if you are not executing "much code" you are still allocating stuff when you invoke a method that does nothing. > The guards help in preventing object allocation and executing useless code. > But please start a discussion on the mailing list, not here in the GH PR: Thanks @eolivelli for your comments and suggestions. Updating the code style does require a lot of discussion. I'm going to temporarily close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
