BewareMyPower commented on issue #12087:
URL: https://github.com/apache/pulsar/issues/12087#issuecomment-928669196


   I updated the PIP now, PTAL @eolivelli .
   
   The methods are renamed. But I don't pass the `EntryContext` object  to 
`PayloadConverter#afterConnect`. The reason is similar as I've said before, the 
entry context might not be the actual message context. We should record the 
actual message context in `PayloadConverter` implementation.
   
   Here's an example, see 
[CustomBatchConverter](https://github.com/apache/pulsar/pull/12088/files#diff-4af2bb02ccc23bc94f852308aa50284cdc9aa521f9db49cff94963625fa1c02a).
 The number of messages is retrieved from payload, not the entry context.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to