eolivelli commented on issue #12087: URL: https://github.com/apache/pulsar/issues/12087#issuecomment-930048387
we should also make it clear to what happens to the we should move everything in this form `void convert(EntryContext context, MessagePayload payload, Schema<T> schema, Consumer<Message<T> consumer);` this way the loop is performed inside the method body: * the lifecycle is clearer * no need for additional lifecycle methods * in the future it can be called by **multiple threads** * the `convert` method has full control over the loop and can handle errors/refcounts better -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
