315157973 commented on a change in pull request #12223:
URL: https://github.com/apache/pulsar/pull/12223#discussion_r718386669
##########
File path:
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -1592,10 +1592,21 @@ synchronized void ledgerClosed(final LedgerHandle lh) {
}
synchronized void createLedgerAfterClosed() {
- STATE_UPDATER.set(this, State.CreatingLedger);
- this.lastLedgerCreationInitiationTimestamp =
System.currentTimeMillis();
- mbean.startDataLedgerCreateOp();
- asyncCreateLedger(bookKeeper, config, digestType, this,
Collections.emptyMap());
+ if(isNeededCreateNewLedgerAfterCloseLedger()) {
+ log.info("[{}] Creating a new ledger after closed", name);
+ STATE_UPDATER.set(this, State.CreatingLedger);
+ this.lastLedgerCreationInitiationTimestamp =
System.currentTimeMillis();
+ mbean.startDataLedgerCreateOp();
+ asyncCreateLedger(bookKeeper, config, digestType, this,
Collections.emptyMap());
+ }
+ }
+
+ synchronized boolean isNeededCreateNewLedgerAfterCloseLedger() {
Review comment:
We don't know the logic of subsequent calls to this method, whether the
same lock (ML object) is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
