gaoran10 commented on a change in pull request #12215:
URL: https://github.com/apache/pulsar/pull/12215#discussion_r718419615



##########
File path: 
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java
##########
@@ -632,25 +632,29 @@ protected void 
internalDeletePartitionedTopic(AsyncResponse asyncResponse, boole
                     return;
                 }
             }
+            // Only tries to delete the authentication policies for 
partitioned topic when all its partitions are
+            // successfully deleted
+            
pulsar().getBrokerService().deleteTopicAuthenticationWithRetry(topicName.toString());

Review comment:
       Maybe we need to add the delete topic authentication policies in the 
delete topic async operation chain? For example, if delete topic authentication 
failed, the topic deleted operation should be failed, we could retry delete 
topic authentication 5 times or more.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to