aahmed-se commented on a change in pull request #12181:
URL: https://github.com/apache/pulsar/pull/12181#discussion_r718786230
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1018,14 +1021,17 @@ private long getHighestSequenceId(OpSendMsg op) {
}
private void releaseSemaphoreForSendOp(OpSendMsg op) {
- if (semaphore.isPresent()) {
- semaphore.get().release(isBatchMessagingEnabled() ?
op.numMessagesInBatch : 1);
- }
+ semaphore.ifPresent(semaphore -> semaphore.release(
+ Math.min(
+ maxPermits - semaphore.availablePermits(),
Review comment:
We are not trying to solve all of the issues here, this is a simple
overflow protection fix.
The root cause still has to be figured out but this is simpler alternative
to implementing a bounded semaphore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
