merlimat commented on a change in pull request #12181:
URL: https://github.com/apache/pulsar/pull/12181#discussion_r718811926
##########
File path:
pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java
##########
@@ -1790,9 +1796,15 @@ private void batchMessageAndSend() {
}
} catch (PulsarClientException e) {
Thread.currentThread().interrupt();
- semaphore.ifPresent(s ->
s.release(batchMessageContainer.getNumMessagesInBatch()));
+ semaphore.ifPresent(s -> s.release(Math.min(
+ maxPermits - s.availablePermits(),
+ batchMessageContainer.getNumMessagesInBatch()))
Review comment:
So, it's actually preferable to have an exception that identifies that
we have an issue (provided that we can restart from there) rather than just
masking the problem. That is, until a proper solution for the root cause is
implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
