eolivelli commented on a change in pull request #12242:
URL: https://github.com/apache/pulsar/pull/12242#discussion_r721073350
##########
File path:
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/PersistentTopics.java
##########
@@ -2662,7 +2662,7 @@ public void getDispatchRate(@Suspended final
AsyncResponse asyncResponse,
}
@POST
- @Path("/{tenant}/{namespace}/{topic}/dispatchRate")
+ @Path("/{tenant}/{namespace}/{topic}/{resetMode}/dispatchRate")
Review comment:
This is a breaking API change.
Can we use a query string parameter?
##########
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -2370,23 +2370,27 @@ void setInactiveTopicPolicies(String topic
* Set message-dispatch-rate (topic can dispatch this many messages per
second).
*
* @param topic
+ * @param resetMode
+ * clear the previous rate and reset (default true). if it is
false, merge the two rate
* @param dispatchRate
* number of messages per second
* @throws PulsarAdminException
* Unexpected error
*/
- void setDispatchRate(String topic, DispatchRate dispatchRate) throws
PulsarAdminException;
Review comment:
Here and below we are introducing breaking API changes
You can deprecate this method and add a new one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
