yuruguo commented on a change in pull request #12242:
URL: https://github.com/apache/pulsar/pull/12242#discussion_r722822017
##########
File path:
pulsar-client-admin-api/src/main/java/org/apache/pulsar/client/admin/Topics.java
##########
@@ -2370,23 +2370,27 @@ void setInactiveTopicPolicies(String topic
* Set message-dispatch-rate (topic can dispatch this many messages per
second).
*
* @param topic
+ * @param resetMode
+ * clear the previous rate and reset (default true). if it is
false, merge the two rate
* @param dispatchRate
* number of messages per second
* @throws PulsarAdminException
* Unexpected error
*/
- void setDispatchRate(String topic, DispatchRate dispatchRate) throws
PulsarAdminException;
Review comment:
The method `setDispatchRate(String topic, DispatchRate dispatchRate)`
will not be used anywhere after introducing new option `--reset-mode`, and its
implementation will also change in order to adapt to the new option, so I think
it could be possible to directly replace it with `setDispatchRate(String topic,
boolean resetMode, DispatchRate dispatchRate)`. Maybe we can ask other people's
ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
